Section 07: Stale Annotations and Decorative Banners

Status: Not Started Goal: Remove ~85 stale plan annotations from completed plans, ~198 decorative banner comments, and 8+ bare TODO comments from production code across all compiler crates. Preserve annotations from active plans (repr-opt §07, aot-perf). Context: Plan annotations are temporary scaffolding — they aid navigation during active development but MUST be removed when the plan completes. Stale annotations from completed plans (hygiene-full sections 01/03/04, codegen-purity, rc-header-elem-dec) remain in production code. Decorative banners (// ===, // ---) violate style rules.

07.1 Remove Stale TPR Annotations

File(s): Multiple files across ori_parse, ori_llvm, ori_repr

Active plans (PRESERVE these annotations):

§07.x, TPR-07-* — repr-opt Section 07 (Enum Repr, in-progress)
Section 01.x in ori_llvm — repr-opt Section 01 (if still active)
BUG-04-* — bug tracker references (always acceptable)

Stale (REMOVE):

07.2 Remove Decorative Banners

File(s): Multiple files across ori_types, ori_rt, ori_parse

Decorative banners (// ===, // ---, // ───) in production code violate style rules. Replace with plain // Section name comments. There are ~198 instances across the compiler (not 37 as originally estimated). Known high-count locations (representative, not exhaustive):

ori_types/src/unify/mod.rs — 10 decorative banners
ori_types/src/infer/mod.rs — 22 decorative banners
ori_types/src/check/bodies/mod.rs — 2 banners
ori_types/src/check/signatures/mod.rs — 6 banners
ori_rt/src/format/mod.rs — 12 banners
ori_parse/src/cursor/mod.rs — 2 banners
ori_parse/src/outcome/mod.rs — 5 banners
ori_parse/src/error/kind/mod.rs — 8 banners
Plus ~131 more across ori_types, ori_llvm, ori_arc, ori_eval, ori_patterns, ori_ir, oric, ori_diagnostic, ori_fmt, ori_rt
grep -rn "// ===\|// ---\|// ───\|// ──" compiler/*/src/ --include="*.rs" | grep -v test to find all instances (includes unicode dash banners // ── which the original grep missed; the // prefix avoids matching legitimate docs)- [ ] Replace each with a plain // Section name comment (keep the descriptive text, remove the decoration)
Approach: Process one crate at a time (ori_types first — highest count at ~50+, then ori_rt, ori_llvm, ori_eval, etc.) to keep commits manageable- [ ] Verify: grep -rn "// ===\|// ---\|// ───\|// ──" compiler/*/src/ --include="*.rs" | grep -v test | wc -l returns 0
/tpr-review passed — independent review found no critical or major issues (or all findings triaged)
/impl-hygiene-review passed — hygiene review clean. MUST run AFTER /tpr-review is clean.
Subsection close-out (07.2) — MANDATORY before starting the next subsection. Run /improve-tooling retrospectively on THIS subsection’s debugging journey (per .claude/skills/improve-tooling/SKILL.md “Per-Subsection Workflow”): which diagnostics/ scripts you ran, where you added dbg!/tracing calls, where output was hard to interpret, where test failures gave unhelpful messages, where you ran the same command sequence repeatedly. Forward-look: what tool/log/diagnostic would shorten the next regression in this code path by 10 minutes? Implement improvements NOW (zero deferral) and commit each via SEPARATE /commit-push using a valid conventional-commit type (build(diagnostics): ... — surfaced by section-07.2 retrospective — build/test/chore/ci/docs are valid; tools(...) is rejected by the lefthook commit-msg hook). Mandatory even when nothing felt painful. If genuinely no gaps, document briefly: “Retrospective 07.2: no tooling gaps”. Update this subsection’s status in section frontmatter to complete.
/sync-claude section-close doc sync — verify Claude artifacts across all section commits. Map changed crates to rules files, check CLAUDE.md, canon.md. Fix drift NOW.
Repo hygiene check — run diagnostics/repo-hygiene.sh --check and clean any detected temp files.

07.3 Resolve Bare TODOs

File(s): Multiple files across ori_types, ori_eval

Bare TODOs without plan references are non-actionable. Each must be either: (a) filed as a bug via /add-bug, (b) tracked in an existing plan, or (c) removed if already resolved.

Known locations:

ori_types/src/infer/expr/control_flow.rs:576 — TODO(inference): ForLoopParams struct
ori_types/src/infer/expr/constructors.rs:94 — TODO: await inference
ori_types/src/infer/expr/type_resolution.rs:53 — TODO: fixed list support
ori_types/src/check/registration/traits.rs:244 — TODO: bounds on associated type
ori_eval/src/interpreter/can_eval/mod.rs:119 — TODO(canonicalization)
ori_eval/src/exec/decision_tree/mod.rs:266,276 — TODO(section-07)
For each TODO: determine if the work is already tracked elsewhere
If untracked: file via /add-bug or add to relevant plan section
If resolved: remove the comment
If genuinely deferred with plan reference: convert to  format
/tpr-review passed — independent review found no critical or major issues (or all findings triaged)
/impl-hygiene-review passed — hygiene review clean. MUST run AFTER /tpr-review is clean.
Subsection close-out (07.3) — MANDATORY before starting the next subsection. Run /improve-tooling retrospectively on THIS subsection’s debugging journey (per .claude/skills/improve-tooling/SKILL.md “Per-Subsection Workflow”): which diagnostics/ scripts you ran, where you added dbg!/tracing calls, where output was hard to interpret, where test failures gave unhelpful messages, where you ran the same command sequence repeatedly. Forward-look: what tool/log/diagnostic would shorten the next regression in this code path by 10 minutes? Implement improvements NOW (zero deferral) and commit each via SEPARATE /commit-push using a valid conventional-commit type (build(diagnostics): ... — surfaced by section-07.3 retrospective — build/test/chore/ci/docs are valid; tools(...) is rejected by the lefthook commit-msg hook). Mandatory even when nothing felt painful. If genuinely no gaps, document briefly: “Retrospective 07.3: no tooling gaps”. Update this subsection’s status in section frontmatter to complete.
/sync-claude section-close doc sync — verify Claude artifacts across all section commits. Map changed crates to rules files, check CLAUDE.md, canon.md. Fix drift NOW.
Repo hygiene check — run diagnostics/repo-hygiene.sh --check and clean any detected temp files.

07.R Third Party Review Findings

None.

07.T Test Strategy

This section is pure comment/annotation cleanup with zero code changes. The test strategy is lightweight.

Verify timeout 150 ./test-all.sh passes after each batch of annotation removals (per-crate batching recommended)
Verify ./clippy-all.sh clean (comment removal should not affect clippy, but verify)
Structural invariant verification commands (run after all changes):
- bash .claude/skills/impl-hygiene-review/plan-annotations.sh reports only active plan annotations
- grep -rn "// ===\|// ---\|// ───\|// ──" compiler/*/src/ --include="*.rs" | grep -v test | wc -l returns 0
- All bare TODOs either filed, tracked, or removed

07.N Completion Checklist

All stale plan annotations removed (only active plan annotations remain)
All decorative banners replaced with plain section comments
All bare TODOs resolved (filed, tracked, or removed)
timeout 150 ./test-all.sh passes (zero behavioral changes)
./clippy-all.sh clean
/tpr-review covering Section 07
/impl-hygiene-review
/improve-tooling retrospective completed — MANDATORY at section close, after both reviews are clean. Reflect on the section’s debugging journey (which diagnostics/ scripts you ran, which command sequences you repeated, where you added ad-hoc dbg!/tracing calls, where output was hard to interpret) and identify any tool/log/diagnostic improvement that would have made this section materially easier OR that would help the next section touching this area. Implement every accepted improvement NOW (zero deferral) and commit each via SEPARATE /commit-push. The retrospective is mandatory even when nothing felt painful — that is exactly when blind spots accumulate. See .claude/skills/improve-tooling/SKILL.md “Retrospective Mode” for the full protocol.