100%

review-plan-reshape

Goal

Reshape /review-plan to drop its up-front TPR round-loop (Step 6) and shed single-section-content audit to /review-section, keeping only the cross-section structural passes.

Dependency

Pairs with S3 (review-section owns the shed content steps).

Implementation Sketch

Remove the Step 6 TPR round-loop from the review_plan.py up-front state machine and the single-section audit/editor/verdict steps /review-section now owns; KEEP _step_1_precheck (cross-section) + _step_1_7_integrity_audit (INV-19 predecessor integrity) + _step_1_7_materiality_return (the §02.A Pre-Halt materiality-verdict autopilot sub-step of the 1.7 flow). _step_1_7_integrity_audit dispatches to Step 2 on THREE paths — the v7-skip path (review_plan.py:1336), the clean-audit path (review_plan.py:1399), AND _step_1_7_materiality_return.non_material; after the shed ALL THREE MUST clean-exit the reduced pipeline instead (Step 2 no longer exists). The shed removes Steps 2-9 wholesale, including Step 4’s /tp-help blind-spots dispatch — so prune the caller_exit_reason_handlers."review-plan"."tp-help" block in orchestration-rules.json as part of the same cut. Update .claude/skills/review-plan/SKILL.md + step-*.md references; update the review_plan + plan_orchestrator tests.

Spec References

scripts/plan_orchestrator/review_plan.py; .claude/skills/review-plan/SKILL.md + step-*.md; scripts/review_plan_runtime/tests/; .claude/rules/orchestration-rules.json (caller_exit_reason_handlers).

Verification

  • Reduced-pipeline parity: review_plan.py with only _step_1_precheck (cross-section) + _step_1_7_integrity_audit (INV-19 predecessor integrity) + _step_1_7_materiality_return (§02.A Pre-Halt materiality verdict) emits a clean cross-section structural pass and runs no Steps 2-9 single-section-content work. All three _step_1_7_integrity_audit Step-2 dispatch paths — v7-skip (review_plan.py:1336), clean-audit (review_plan.py:1399), and _step_1_7_materiality_return.non_material — clean-exit the reduced pipeline (regression-pinned) instead of resuming the removed Step 2.
  • Shed-path end-to-end: the dropped single-section audit/editor/verdict (Steps 2-9) runs end-to-end via /review-section on a representative section, confirming the responsibility moved rather than vanished.
  • exit_reason routing completeness: the reduced SKILL.md exit_reason routing table (Steps 1 + 1.7 only) satisfies caller_exit_reason_handlers completeness per orchestration-rules.json — dropping Steps 2-9 strands no exit_reason the /continue-roadmap Step 2 classifier expects.
  • Layer scope: tooling/orchestration work; compiler layer matrix (L1-L12 per layer-coverage.md §1) is N/A — no Ori-language runtime surface. Per-layer success_criteria are plan.json-engine-written.

Work Items

  • Drop the Step 6 TPR round-loop from the review_plan.py up-front state machine.
  • Shed steps 2-9 single-section-content audit to /review-section; keep Steps 1 + 1.7 cross-section structural (incl. _step_1_7_materiality_return). Rewire ALL THREE _step_1_7_integrity_audit Step-2 dispatch paths — v7-skip (review_plan.py:1336), clean-audit (review_plan.py:1399), and _step_1_7_materiality_return.non_material — to clean-exit the reduced pipeline instead of dispatching the removed Step 2. Prune the caller_exit_reason_handlers."review-plan"."tp-help" block in orchestration-rules.json (Step 4 /tp-help is shed).
  • Update .claude/skills/review-plan/SKILL.md + step-*.md references to the reshaped pipeline. Remove from SKILL.md the four Step-6 surfaces so no dangling Step-6 prose survives: (a) the Step 6 TPR round-loop handler prose; (b) the finding_triage hook dispatch-table row; (c) the Step 6 exit_reason dispatch references (per decisions/31); (d) the Step 8 autopilot-pause-leak banned-shape patterns referencing the Step 6 Skill(tpr-review) return. The shed removes Steps 2-9 wholesale — ALSO remove the SKILL.md Step 4 /tp-help blind-spots dispatch surfaces (SKILL.md lines 5, 37, 72, 98, 120-126) + the Step 5 editor / Steps 7-9 verdict surfaces, leaving only the Steps 1 + 1.7 cross-section dispatcher.
  • Update review_plan.py / review_plan_runtime tests for the reshaped state machine, including the reduced-pipeline parity check and the exit_reason routing-completeness assertion. ALSO update the plan_orchestrator tp-help tests that list review-plan as a /tp-help caller — scripts/plan_orchestrator/tests/test_tp_help_caller_routing_matrix.py:52 + test_tp_help_exit_reason_parity.py:40 — to drop the shed review-plan → /tp-help caller edge.