Section 01: Hygiene & Targeted Fixes

Status: Not Started Goal: Split three bloated files that downstream sections must extend (traits/mod.rs at 765 lines, aims_pipeline.rs at 590 lines, instr_dispatch.rs at 587 lines), and fix BUG-04-029 (shift overflow checks) which is a correctness prerequisite for LLVM metadata work. After this section, all files touched by the plan are under the 500-line limit and the LLVM backend produces correct shift behavior.

Success Criteria:

compiler/ori_types/src/registry/traits/mod.rs is under 500 lines (currently 765) — wc -l verification
compiler/ori_arc/src/pipeline/aims_pipeline.rs is under 500 lines (currently 590) — wc -l verification
compiler/ori_llvm/src/codegen/arc_emitter/instr_dispatch.rs is under 500 lines (currently 587) — wc -l verification
Verified BUG-04-029 shift overflow checks are already implemented (checked_shl/checked_shr in checked_ops.rs) — just needs test verification
./test-all.sh green — no regressions from file splits or shift fix

Context: Section 07 (Algebra Law Schema) adds AlgebraLawSet fields to TraitEntry and ImplEntry in traits/mod.rs. Adding ~50 lines of algebra metadata to a 765-line file would push it well over the limit. Section 09 adds a normalization step to the AIMS pipeline, requiring modifications to aims_pipeline.rs. Section 04 adds TBAA metadata attachment at ArcInstr::Project emission sites in instr_dispatch.rs. All three files must be split first. BUG-04-029 (shift overflow) was already fixed — checked_shl()/checked_shr() in checked_ops.rs now emit negative count, width, and overflow checks. This section only verifies the fix, not implements it.

Depends on: Nothing.

01.1 Split TraitRegistry (traits/mod.rs)

File(s): compiler/ori_types/src/registry/traits/mod.rs (766 lines)

The TraitRegistry module currently contains: registry data structures (TraitEntry, ImplEntry, method storage), registration logic (adding traits/impls), resolution logic (looking up methods, checking satisfaction), and object safety checking. Extract resolution into a submodule.

01.2 Split AIMS Pipeline (aims_pipeline.rs)

File(s): compiler/ori_arc/src/pipeline/aims_pipeline.rs (590 lines)

The AIMS pipeline file contains: AimsPipelineConfig, AimsPipelineResult, the main run_aims_pipeline function, TRMC normalization logic (normalize_with_trmc), interprocedural pipeline orchestration (run_aims_pipeline_all), and ownership application. Extract TRMC normalization and interprocedural orchestration.

01.3 Split instr_dispatch.rs (BLOAT)

File(s): compiler/ori_llvm/src/codegen/arc_emitter/instr_dispatch.rs (587 lines — over 500-line limit)

Section 04 will add TBAA metadata attachment at ArcInstr::Project emission sites in this file. It’s already over the limit and will grow further. Split now.

01.4 Fix BUG-04-029 Shift Overflow Checks (ALREADY FIXED)

Status: Already implemented in compiler/ori_llvm/src/codegen/ir_builder/checked_ops.rs.

BUG-04-029 was fixed in a prior commit. IrBuilder::checked_shl() and checked_shr() now emit:

icmp slt count, 0 → panic “shift by negative count”
icmp sge count, 64 → panic “shift count overflow”
For shl: roundtrip check (result >> count) != lhs → panic “integer overflow”

The strategy dispatch (operators/strategy.rs) already calls checked_shl/checked_shr (lines 136-137).

Verify existing implementation passes in debug: timeout 150 ./test-all.sh
Verify existing implementation passes in release: cargo b --release && timeout 150 ./test-all.sh
Update BUG-04-029 in bug tracker: change - [ ] to - [x] in plans/bug-tracker/section-04-codegen-llvm.md line 137 and add . As of 2026-04-04, the fix exists in checked_ops.rs but the bug tracker entry is still unchecked.
/tpr-review passed — independent review found no critical or major issues (or all findings triaged)
/impl-hygiene-review passed — hygiene review clean. MUST run AFTER /tpr-review is clean.
Subsection close-out (01.4) — MANDATORY before starting the next subsection. Run /improve-tooling retrospectively on THIS subsection’s debugging journey (per .claude/skills/improve-tooling/SKILL.md “Per-Subsection Workflow”): which diagnostics/ scripts you ran, where you added dbg!/tracing calls, where output was hard to interpret, where test failures gave unhelpful messages, where you ran the same command sequence repeatedly. Forward-look: what tool/log/diagnostic would shorten the next regression in this code path by 10 minutes? Implement improvements NOW (zero deferral) and commit each via SEPARATE /commit-push using a valid conventional-commit type (build(diagnostics): ... — surfaced by section-01.4 retrospective — build/test/chore/ci/docs are valid; tools(...) is rejected by the lefthook commit-msg hook). Mandatory even when nothing felt painful. If genuinely no gaps, document briefly: “Retrospective 01.4: no tooling gaps”. Update this subsection’s status in section frontmatter to complete.
/sync-claude section-close doc sync — verify Claude artifacts across all section commits. Map changed crates to rules files, check CLAUDE.md, canon.md. Fix drift NOW.
Repo hygiene check — run diagnostics/repo-hygiene.sh --check and clean any detected temp files.

01.R Third Party Review Findings

None.

01.N Completion Checklist

Exit Criteria: All three target files are under 500 lines (traits/mod.rs, aims_pipeline.rs, instr_dispatch.rs). timeout 150 ./test-all.sh passes with 0 failures in both debug and release builds. BUG-04-029 shift overflow checks verified passing in both builds.